Nexus: worker, workflow-backed operations, and workflow caller #813
+5,344
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
nexus
branch
2 times, most recently
from
a845a6f to
7a121bb
Compare
dandavison
force-pushed
the
nexus
branch
10 times, most recently
from
862e4f9 to
8ac0192
Compare
dandavison
force-pushed
the
nexus
branch
4 times, most recently
from
8940d51 to
520aecf
Compare
dandavison
force-pushed
the
nexus
branch
2 times, most recently
from
2fc971f to
8bd6011
Compare
dandavison
force-pushed
the
nexus
branch
2 times, most recently
from
5d54f48 to
8ddfb94
Compare
dandavison
force-pushed
the
nexus
branch
7 times, most recently
from
fa3e8ec to
f7bf47b
Compare
- Expose nexus.client(), nexus.info() - Don't expose contextvar
Accidentally broken at f8077c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Python Temporal Nexus implementation.
Temporal SDK PR to accompany
samples-pythonPR Nexus samples samples-python#174Contains Nexus worker, components for users to define workflow-backed Nexus operations, and the ability to start and cancel a Nexus operation from a workflow.
Notes for reviewers
nexusrpc.handler.start_workflowis a top-level static function, but currently there's still a public contextvar objectnexusrpc.handler.temporal_operation_context. Let's settle on approach there. If we're using module-level getters I think they need to be named something likeget_client()etc, despite the fact that we haveactivity.metric_meter()? Little bit more discussion needed there.